seoxi/magick-rust
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: make disable-hdri default to fix compile error

Browse Source 
By making the disable-hdri feature a default, the `quantum_range()` function
will be one which computes a value for `QuantumRange` based on a constant
that rust-bindgen seemingly does not have any problem discovering.

cargo test passes
This commit is contained in:
Nathan Fiedler
2023-09-23 11:43:07 -07:00
parent ef1867e9f9
commit 8a9536d83a
4 changed files with 11 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
README.md
View File

@ -42,29 +42,6 @@ When building on Windows, you will need to set the `IMAGE_MAGICK_DIR` environmen
> cargo test
```
### Build Troubleshooting
#### Error: cannot find value `QuantumRange` in module bindings
When attempting to build the library, you might see an error like this one:
```
error[E0425]: cannot find value `QuantumRange` in module `bindings`
--> C:\Users\charlie\.cargo\registry\src\github.com-1ecc6299db9ec823\magick_rust-0.9.0\src\wand\magick.rs:337:80
|
337 | if bindings::MagickSepiaToneImage(self.wand, threshold * bindings::QuantumRange) == bindings::MagickBooleanType::MagickTrue {
|
^^^^^^^^^^^^ not found in `bindings`
error: aborting due to previous error
```
See [issue 40](https://github.com/nlfiedler/magick-rust/issues/40) on GitHub for some background. The issue seems to be that with HDRI disabled, rust-bindgen will not produce the bindings needed for the "quantum range" feature of ImageMagick (see [issue 316](https://github.com/rust-lang/rust-bindgen/issues/316)). To work-around this issue, you can disable HDRI support in your `Cargo.toml` file, like so:
```
magick_rust = { version = "0.18.0", features = ["disable-hdri"] }
```
## Documentation
The API documentation is available at [github pages](https://nlfiedler.github.io/magick-rust) since the docs.rs system has a hard time building anything that requires an external library that is not wrapped in a "sys" style library. See [issue 57](https://github.com/nlfiedler/magick-rust/issues/57) for the "create a sys crate request."