seoxi/magick-rust
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove /usr/local/lib from rustc link search

Browse Source 
If /usr/local/lib is in the search path, a Homebrew installed libJPEG
can end up conflicting with the system libJPEG as such:

```
$ otool -L /System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO
/System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO:
... snip ...
    /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib (compatibility version 1.0.0, current version 1.0.0)
... snip ...
```

```
$ cargo clean && cargo test
... snip ...
Doc-tests magick_rust
dyld: Symbol not found: __cg_jpeg_resync_to_restart
  Referenced from: /System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO
  Expected in: /usr/local/lib/libJPEG.dylib
 in /System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO
```

Removing the /usr/local/lib link search path allows successful
compilation and testing on my OSX 10.11.6, with jpeg 8d installed into
/usr/local/lib via Homebrew. I realize this might be a problem with my
setup and not a universal issue, but as Homebrew is so common I thought
I'd submit this patch anyways.
This commit is contained in:
Pete Gadomski
2016-08-25 07:52:11 -06:00
parent 094e24d859
commit 7563231707
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
build.rs
View File

@ -92,10 +92,6 @@ fn main() {
panic!("missing {}, run xcode-select --install", LIBPATH); panic!("missing {}, run xcode-select --install", LIBPATH);
} }
cmd.env("DYLD_LIBRARY_PATH", LIBPATH); cmd.env("DYLD_LIBRARY_PATH", LIBPATH);
// For the sake of easily building and testing on Mac, include
// the path to MagickWand. Chances are MagickWand is in
// /usr/local/lib, or somewhere else that rustc can find it.
println!("cargo:rustc-link-search=native=/usr/local/lib");
} }
let mut output_arg = String::from("--output"); let mut output_arg = String::from("--output");
output_arg.push('='); output_arg.push('=');